Skip to content

Conversation

bdrodes
Copy link
Contributor

@bdrodes bdrodes commented Jun 27, 2025

Updates how padding is modeled for openSSL.

bdrodes added 3 commits June 26, 2025 09:18
# Conflicts:
#	cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/AlgToAVCFlow.qll
#	cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/PaddingAlgorithmInstance.qll
@Copilot Copilot AI review requested due to automatic review settings June 27, 2025 17:56
@bdrodes bdrodes requested a review from a team as a code owner June 27, 2025 17:56
@github-actions github-actions bot added the C++ label Jun 27, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@nicolaswill nicolaswill changed the title Openssl padding refactor Quantum: Refactor OpenSSL padding modeling Jun 29, 2025
Copy link
Contributor

@nicolaswill nicolaswill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QL-for-QL alerts

@bdrodes
Copy link
Contributor Author

bdrodes commented Jun 30, 2025

QL-for-QL alerts

Maybe I'm using the UI wrong, but I seem to only detect these by scrolling through the diffs and hope I don't miss one. I saw 3 and I corrected those. Hopefully I didn't miss any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants